fix: set http response chartset to utf-8 when using table format #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3571 +/- ##
==========================================
- Coverage 85.36% 85.06% -0.31%
==========================================
Files 910 911 +1
Lines 152033 152425 +392
==========================================
- Hits 129784 129661 -123
- Misses 22249 22764 +515 |
sunng87
approved these changes
Mar 24, 2024
tisonkun
approved these changes
Mar 25, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
fixed the problem mentioned in this PR: #3539
What's changed and what's your intention?
The table format contains non-ASCII characters, and the content-type does not specify a character set. Although most clients will try to using UTF-8, but we cannot make this assumption and need to explicitly set it.
before:
after:
Checklist